Messages in this thread Patch in this message | | | Date | Sun, 8 Jun 2008 15:28:23 +0400 | From | "Q (Igor Mammedov)" <> | Subject | Re: [linux-cifs-client] [PATCH] cifs: fix oops on mount when CONFIG_CIFS_DFS_UPCALL is enabled |
| |
A quick look trough cifs_mount and cifs_parse_mount_options functions shows that mount will fail anyway with error EINVAL when 'data' = NULL. May be moving NULL check at the beginning of function will be better in this case. From 83d523d13556e98283d0fe34394819f83368efb3 Mon Sep 17 00:00:00 2001 From: q <q@q-desktop.(none)> Date: Sun, 8 Jun 2008 08:15:07 -0400 Subject: [PATCH] [CIFS] Fix OOPs when 'data' is NULL
Signed-off-by: niallain@gmail.com <q@q-desktop.(none)> --- fs/cifs/cifsfs.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c index e9f4ec7..aee6b9d 100644 --- a/fs/cifs/cifsfs.c +++ b/fs/cifs/cifsfs.c @@ -102,6 +102,9 @@ cifs_read_super(struct super_block *sb, void *data, #endif int rc = 0; + if (!data) + return -EINVAL; + /* BB should we make this contingent on mount parm? */ sb->s_flags |= MS_NODIRATIME | MS_NOATIME; sb->s_fs_info = kzalloc(sizeof(struct cifs_sb_info), GFP_KERNEL); -- 1.5.4.3
| |