Messages in this thread | | | Date | Sun, 8 Jun 2008 07:29:42 -0300 | From | Mauro Carvalho Chehab <> | Subject | Re: [RFC PATCH] v4l: saa7134: fix multiple clients access (and oops) |
| |
On Sun, 8 Jun 2008 00:48:40 +0200 Marcin Slusarz <marcin.slusarz@gmail.com> wrote:
> While looking for a reason of multiple oopses in empress_querycap as reported > by kerneloops.org I noticed that only first open of device initializes > struct_file->private_data properly. (Closing the device was broken too). > > So initialize private_date and free all resources on last close. > I think this change will fix oops in empress_querycap. > > http://kerneloops.org/guilty.php?guilty=empress_querycap&version=2.6.25-release&start=1671168&end=1703935&class=oops > > Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com> > Cc: Mauro Carvalho Chehab <mchehab@infradead.org> > Cc: video4linux-list@redhat.com > --- > > Compile tested only. Please test on real hardware.
Thanks.
The patch looks sane to my eyes. I'll apply at the tree, in order to allow more people to test it.
Cheers, Mauro
| |