Messages in this thread | | | Date | Sun, 8 Jun 2008 17:12:35 -0700 | From | Andrew Morton <> | Subject | Re: [Patch 03/18] define BYTES_PER_WORD |
| |
On Fri, 6 Jun 2008 11:44:55 -0500 Dean Nelson <dcn@sgi.com> wrote:
> Add a BYTES_PER_WORD #define. > > Signed-off-by: Dean Nelson <dcn@sgi.com> > > --- > > drivers/misc/sgi-xp/xp.h | 3 +++ > 1 file changed, 3 insertions(+) > > Index: linux-2.6/drivers/misc/sgi-xp/xp.h > =================================================================== > --- linux-2.6.orig/drivers/misc/sgi-xp/xp.h 2008-05-30 13:59:29.580809165 -0500 > +++ linux-2.6/drivers/misc/sgi-xp/xp.h 2008-05-30 14:00:00.200614111 -0500 > @@ -19,6 +19,9 @@ > #include <asm/sn/types.h> > #include <asm/sn/bte.h> > > +/* >>> Add this #define to some linux header file some day. */
The patches fill the code with this ">>>" string - which can cause false positives when people are searching for git rejects. Although I (and I suspect most other people) search for "<<<<<<<".
> +#define BYTES_PER_WORD sizeof(void *)
Dunno if this is a desirable thing to have, really. A "word" is a somewhat ill-defined thing. The definition you have here is always equal to BYTES_PER_LONG. If BYTES_PER_LONG is inappropriate then BYTES_PER_POINTER would be clearer.
| |