Messages in this thread |  | | | Date | Sun, 8 Jun 2008 19:12:00 +0200 | | From | Bernhard Walle <> | | Subject | Re: [patch 2/3] Add flags parameter to reserve_bootmem_generic() |
| |
* WANG Cong <xiyou.wangcong@gmail.com> [2008-06-08 22:26]: > > Since 'reserve_bootmem_generic' is changed from 'void' to 'int', > we should check its return value for failure when possible, right?
That may make sense here, but that's unrelated to my change.
Just because the error *can* be caught by checking the return value doesn't mean that it *must* be caught always. It was silently ignored before in the efi_reserve_bootmem() function before, and so is it now. No behaviour change.
Bernhard -- Bernhard Walle, SUSE LINUX Products GmbH, Architecture Maintenance
|  |