[lkml]   [2008]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [patch 2/3] Add flags parameter to reserve_bootmem_generic()
    * WANG Cong <> [2008-06-08 22:26]:
    > Since 'reserve_bootmem_generic' is changed from 'void' to 'int',
    > we should check its return value for failure when possible, right?

    That may make sense here, but that's unrelated to my change.

    Just because the error *can* be caught by checking the return value
    doesn't mean that it *must* be caught always. It was silently ignored
    before in the efi_reserve_bootmem() function before, and so is it now.
    No behaviour change.

    Bernhard Walle, SUSE LINUX Products GmbH, Architecture Maintenance

     \ /
      Last update: 2008-06-08 19:15    [W:0.018 / U:3.148 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site