lkml.org 
[lkml]   [2008]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH -mm 02/25] Use an indexed array for LRU variables
    On Sat, 07 Jun 2008 14:43:50 +0900
    KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:

    > > > Index: linux-2.6.26-rc2-mm1/include/linux/mm_inline.h
    > > > ===================================================================
    > > > --- linux-2.6.26-rc2-mm1.orig/include/linux/mm_inline.h 2008-05-23 14:21:21.000000000 -0400
    > > > +++ linux-2.6.26-rc2-mm1/include/linux/mm_inline.h 2008-05-23 14:21:33.000000000 -0400
    > > > @@ -1,40 +1,51 @@
    > > > static inline void
    > > > +add_page_to_lru_list(struct zone *zone, struct page *page, enum lru_list l)
    > > > +{
    > > > + list_add(&page->lru, &zone->list[l]);
    > > > + __inc_zone_state(zone, NR_INACTIVE + l);
    > >
    > > ^ that's a bug, isn't it?
    >
    > this is definitely bug.

    I believe this is correct, actually. I will rename/alias it to
    VMSCAN_BASE or something along those lines.

    > > oh, no it isn't.
    > > Can we rename NR_INACTIVE? Maybe VMSCAN_BASE or something?
    >
    > as far as i remembered, old version use LRU_INACTIVE.

    LRU_* is used to index LRU arrays.

    NR_* is used as an offset into the zone state.

    --
    All rights reversed.


    \
     
     \ /
      Last update: 2008-06-07 16:51    [W:0.027 / U:0.200 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site