Messages in this thread | | | From | "Marco Berizzi" <> | Subject | Re: [patch 00/50] 2.6.25.6 -stable review | Date | Sat, 7 Jun 2008 22:27:58 +0200 |
| |
David Miller wrote:
> From: Herbert Xu <herbert@gondor.apana.org.au> > Date: Tue, 20 May 2008 17:25:11 +0800 > >> On Wed, May 14, 2008 at 10:19:57AM +0200, Marco Berizzi wrote: >> > >> > I hope this helps. >> >> OK found the problem, it was my fault after all :) >> >> Dave, this patch needs to go into stable too. >> >> [IPSEC]: Use the correct ip_local_out function >> >> Because the IPsec output function xfrm_output_resume does its >> own dst_output call it should always call __ip_local_output >> instead of ip_local_output as the latter may invoke dst_output >> directly. Otherwise the return values from nf_hook and dst_output >> may clash as they both use the value 1 but for different purposes. >> >> When that clash occurs this can cause a packet to be used after >> it has been freed which usually leads to a crash. Because the >> offending value is only returned from dst_output with qdiscs >> such as HTB, this bug is normally not visible. >> >> Thanks to Marco Berizzi for his perseverance in tracking this >> down. >> >> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> > > Applied and queued to -stable, thanks!
Hi David,
I don't see this patch in Chris 2.6.25.6 -stable review message.
| |