Messages in this thread | | | Date | Fri, 6 Jun 2008 09:45:56 +0200 | From | Manuel Lauss <> | Subject | Re: [PATCH 9/9] au1xmmc: Add back PB1200/DB1200 MMC activity LED support |
| |
Hi Pierre,
On Thu, Jun 05, 2008 at 11:08:03PM +0200, Pierre Ossman wrote: > On Mon, 19 May 2008 10:08:37 +0200 > Manuel Lauss <mano@roarinelk.homelinux.net> wrote: > > > From 5747bd6933bb212ab83044fa79adf185d248513f Mon Sep 17 00:00:00 2001 > > From: Manuel Lauss <mlau@msc-ge.com> > > Date: Sun, 18 May 2008 16:05:56 +0200 > > Subject: [PATCH] au1xmmc: Add back PB1200/DB1200 MMC activity LED support. > > > > Add back PB1200/DB1200 MMC activity LED support just the way > > it was done in the original driver source. > > > > Signed-off-by: Manuel Lauss <mano@roarinelk.homelinux.net> > > You might want to consider using the LED subsystem now that the MMC > core exports a trigger. Look at my next tree for how sdhci uses it.
I tried that originally. The LED subsystem seems quite complex for something as simple as turning on a bit in a register. I don't have a DB1200 to test so I went the safe route and added a simple callback to toggle the LED bit in the DB1200 FPGA.
I'll try to come up with something over the weekend and then resend the whole series.
Thanks! Manuel Lauss
| |