Messages in this thread | | | From | Jarod Wilson <> | Subject | Re: [PATCH] firewire: fw-ohci: write selfIDBufferPtr before LinkControl.rcvSelfID | Date | Thu, 5 Jun 2008 15:13:27 -0400 |
| |
On Thursday 05 June 2008 02:50:53 pm Stefan Richter wrote: > OHCI 1.1 clause 5.10 requires that selfIDBufferPtr is valid when a 1 is > written into LinkControl.rcvSelfID. > > This driver bug has so far not been known to cause harm because most > chips obviously accept a later selfIDBufferPtr write. > > Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
I vaguely recall discussing this one before. Doesn't seem to have caused any problems in practice, but yeah, should go ahead and be more spec compliant here.
Signed-off-by: Jarod Wilson <jwilson@redhat.com>
-- Jarod Wilson jwilson@redhat.com
| |