lkml.org 
[lkml]   [2008]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] firewire: fw-ohci: write selfIDBufferPtr before LinkControl.rcvSelfID
Date
On Thursday 05 June 2008 02:50:53 pm Stefan Richter wrote:
> OHCI 1.1 clause 5.10 requires that selfIDBufferPtr is valid when a 1 is
> written into LinkControl.rcvSelfID.
>
> This driver bug has so far not been known to cause harm because most
> chips obviously accept a later selfIDBufferPtr write.
>
> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

I vaguely recall discussing this one before. Doesn't seem to have caused any
problems in practice, but yeah, should go ahead and be more spec compliant
here.

Signed-off-by: Jarod Wilson <jwilson@redhat.com>

--
Jarod Wilson
jwilson@redhat.com


\
 
 \ /
  Last update: 2008-06-05 21:17    [W:0.048 / U:3.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site