Messages in this thread Patch in this message | | | Date | Thu, 05 Jun 2008 10:26:44 +0900 | From | KOSAKI Motohiro <> | Subject | Re: [PATCH 1/5] fix incorrect variable type of do_try_to_free_pages() |
| |
> "Smarter retry of costly-order allocations" patch series change behaver of do_try_to_free_pages(). > but unfortunately ret variable tyep unchanged. > > thus, overflow problem is possible. > > > Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
sorry, this patch already get Nishanth-san's ACK. I'll append it and resend by this mail.
---------------------------- fix incorrect variable type of do_try_to_free_pages()
"Smarter retry of costly-order allocations" patch series change behaver of do_try_to_free_pages(). but unfortunately ret variable tyep unchanged.
thus, overflow problem is possible.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> Acked-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- mm/vmscan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Index: b/mm/vmscan.c =================================================================== --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -1317,7 +1317,7 @@ static unsigned long do_try_to_free_page struct scan_control *sc) { int priority; - int ret = 0; + unsigned long ret = 0; unsigned long total_scanned = 0; unsigned long nr_reclaimed = 0; struct reclaim_state *reclaim_state = current->reclaim_state;
| |