Messages in this thread | | | Date | Thu, 05 Jun 2008 01:29:21 +0200 | From | Éric Piel <> | Subject | Re: [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver -- please review! |
| |
05-06-08 01:03, Pavel Machek wrote/a écrit: > Hi! >>> 3) Makes it possible to power the device off. > > But this part is what I don't understand. powering off does not seem > to belong there. Why can't you just use acpi to power down? Not sure what you mean. Are you saying acpi has already a user interface to power up/down a device? If so, I'm not aware of it, is it in /sys ? Or did you mean that there is already a kernel api to turn on/off a device via acpi, no need to access the device directly?
That said, this special /sys interface to power the device off is probably going to be used rarely. It was put there because it is costly to wake the device up each time we want to read it. What I could do is put a timer to turn the device off after 10s of non-usage, and power it on automatically again as soon as the user wants to read some info. That would permit to remove this interface.
Eric
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |