lkml.org 
[lkml]   [2008]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch -v3 21/22] ipr: use memory_read_from_buffer
    Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
    Cc: Brian King <brking@us.ibm.com>
    Cc: James E.J. Bottomley <James.Bottomley@HansenPartnership.com>
    Cc: linux-scsi@vger.kernel.org
    ---
    drivers/scsi/ipr.c | 16 +++++-----------
    1 file changed, 5 insertions(+), 11 deletions(-)

    Index: 2.6-git/drivers/scsi/ipr.c
    ===================================================================
    --- 2.6-git.orig/drivers/scsi/ipr.c
    +++ 2.6-git/drivers/scsi/ipr.c
    @@ -2455,20 +2455,14 @@ static ssize_t ipr_read_trace(struct kob
    struct Scsi_Host *shost = class_to_shost(dev);
    struct ipr_ioa_cfg *ioa_cfg = (struct ipr_ioa_cfg *)shost->hostdata;
    unsigned long lock_flags = 0;
    - int size = IPR_TRACE_SIZE;
    - char *src = (char *)ioa_cfg->trace;
    -
    - if (off > size)
    - return 0;
    - if (off + count > size) {
    - size -= off;
    - count = size;
    - }
    + ssize_t ret;

    spin_lock_irqsave(ioa_cfg->host->host_lock, lock_flags);
    - memcpy(buf, &src[off], count);
    + ret = memory_read_from_buffer(buf, count, &off, ioa_cfg->trace,
    + IPR_TRACE_SIZE);
    spin_unlock_irqrestore(ioa_cfg->host->host_lock, lock_flags);
    - return count;
    +
    + return ret;
    }

    static struct bin_attribute ipr_trace_attr = {
    --


    \
     
     \ /
      Last update: 2008-06-04 14:19    [W:0.022 / U:0.440 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site