lkml.org 
[lkml]   [2008]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] console - Add configurable support for console charset translation
    > This is clearly an improvement. But it is missing this part of the
    > original patch:
    >
    > --- a/drivers/char/vt.c
    > +++ b/drivers/char/vt.c
    > @@ -2198,7 +2198,11 @@ rescan_last_byte:
    > c = 0xfffd;
    > tc = c;
    > } else { /* no utf or alternate charset mode */
    > +#ifdef CONFIG_CONSOLE_TRANSLATIONS
    > tc = vc->vc_translate[vc->vc_toggle_meta ? (c | 0x80) : c];
    > +#else
    > + tc = c;
    > +#endif

    Can we please get the ifdefs tided up before this goes in.

    For the moment this has a NAK from the tty maintainer but if the ifdefs
    turned went into headers where they belong and the code looked like say

    tc = vc_translate(vc, c);

    with two versions of vc_translate (one being vc_translate(x) (x)) it
    might be more reasonable.

    We can't stick random ifdefs in bits of code for arbitary 6K savings or
    the entire kernel would be ifdefs.


    Sor for the moment

    Nacked-by: Alan Cox <alan@redhat.com>

    but scope for change


    \
     
     \ /
      Last update: 2008-06-04 14:19    [W:0.027 / U:3.248 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site