lkml.org 
[lkml]   [2008]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: aperture_64.c: corner case wrong
On Wed, 4 Jun 2008, Ingo Molnar wrote:
> * Thomas Gleixner <tglx@linutronix.de> wrote:
>
> > > So what happened with this? Thomas has merged an "x86:
> > > aperture_64.c: cleanups" from yourself but it appears that half of
> > > this bugfix got applied somewhere and the below part did not?
> >
> > Err, no. I seem to have dropped the patch completely. I'm picking it
> > up again.
>
> no, it was not dropped (we dont drop patches :), here are all the
> arch/x86/kernel/aperture_64.c patches in -tip:
>
> earth4:~/tip> tip-log arch/x86/kernel/aperture_64.c | grep ^#
> # x86/gart: 1edc1ab: x86: agp_gart size checking for buggy device
> # x86/gart: 8c9fd91: x86: checking aperture size order
> # x86/gart: 7677b2e: x86_64: allocate gart aperture from 512M
> # x86/gart: 55c0d72: x86: clean up aperture_64.c
> # x86/gart: 0abbc78: x86, aperture_64: use symbolic constants
> # x86/gart: dd564d0: x86: aperture_64.c: cleanups
>
> so it's commit dd564d0 - but that second chunk Andrew noticed indeed
> went missing in action.

No, the patch was titled: ".... - corner case wrong" its missing and
I'm wondering why.
/me digs into git branches

Thanks,
tglx


\
 
 \ /
  Last update: 2008-06-04 12:51    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site