Messages in this thread | | | From | Roland McGrath <> | Subject | Re: [PATCH] ptrace GET/SET FPXREGS broken | Date | Mon, 30 Jun 2008 14:02:45 -0700 (PDT) |
| |
Thanks for the report. That was indeed a regression from 2.6.24 in ptrace. To match traditional behavior, ptrace should only ever return -EIO for all kinds of errors accessing registers (except for the -ESRCH cases). But it is cleaner for the user_regset calls to use meaningful error codes, and -ENODEV is what makes sense for the !cpu_has_fxsr case. So the right fix for this is in ptrace, not in user_regset.
Ingo, please revert takada's patch and apply the one about to come from me.
Thanks, Roland
| |