lkml.org 
[lkml]   [2008]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] splitlru: memcg swapbacked pages active
    On Mon, 30 Jun 2008, KAMEZAWA Hiroyuki wrote:
    > On Sun, 29 Jun 2008 01:22:22 +0100 (BST)
    > Hugh Dickins <hugh@veritas.com> wrote:
    > >
    > > --- mmotm/mm/memcontrol.c 2008-06-27 13:39:20.000000000 +0100
    > > +++ linux/mm/memcontrol.c 2008-06-27 17:32:29.000000000 +0100
    > > @@ -560,6 +560,8 @@ static int mem_cgroup_charge_common(stru
    > > pc->flags = PAGE_CGROUP_FLAG_CACHE;
    > > if (page_is_file_cache(page))
    > > pc->flags |= PAGE_CGROUP_FLAG_FILE;
    > > + else
    > > + pc->flags |= PAGE_CGROUP_FLAG_ACTIVE;
    > > } else
    > > pc->flags = PAGE_CGROUP_FLAG_ACTIVE;
    > >
    >
    > Hmm, maybe no trouble but we'll have to care shmem's page is not marked as
    > PAGE_CGROUP_FLAG_CACHE but charged by mem_cgroup_charge_cache_page().
    > (I think why shmem is charged as cache is because shmem is used for tmpfs)
    >
    > pc->flags |= PAGE_CGROUP_FLAG_FILE | PAGE_CGROUP_FLAG_ACTIVE;
    >
    > is bad ? (or not work ? I can't catch yet.)

    Sorry, I've tried several times to understand you here, but still don't.

    I thought shmem's page is marked as PAGE_CGROUP_FLAG_CACHE, and is
    charged by mem_cgroup_charge_cache_page(), and that's what memcg wants?

    It is a bit weird that PAGE_CGROUP_FLAG_CACHE and PAGE_CGROUP_FLAG_FILE
    diverge, I'm not thrilled with that: that's an aspect of splitlru
    treating shmem/tmpfs pages as not-file pages, which I'm unhappy with.

    Hugh


    \
     
     \ /
      Last update: 2008-06-30 21:23    [W:4.363 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site