Messages in this thread | | | Date | Tue, 1 Jul 2008 00:36:01 +0800 | From | Harald Welte <> | Subject | Re: [patch v4 02/17] MMC: S3C24XX: Fix the checkpatch.pl errors in the s3cmci driver |
| |
On Mon, Jun 30, 2008 at 05:15:37PM +0100, Ben Dooks wrote: > On Mon, Jun 30, 2008 at 05:50:18PM +0200, Pierre Ossman wrote: > > On Mon, 30 Jun 2008 16:25:49 +0100 > > Ben Dooks <ben-linux@fluff.org> wrote: > > > > > Fix the checkpatch and other problems pointed out by > > > akpm. > > > > > > Signed-off-by: Ben Dooks <ben-linux@fluff.org> > > > > > > > I prefer to have this one merged into 01 as you'll end up with a commit > > that you cannot compile otherwise. Besides, running checkpatch is > > something you do before submitting anyway, not as a separate cleanup. :) > > In this case I kept it seperate as the cleanups where done by myself > as the original driver authour is not interested or too busy to do > these himself. Basically, I was trying to keep the driver and my own > cleanup work seperate.
don't worry about that. Thomas Kleffel is unlikely to return to do any active work on it (I know him personally), and the OpenMoko community will inevitably rebase its patches based on whatever ends up in mainline. So nobody is worried if you merge all that stuff into one patch. It's probably polite to add the significant contributors (such as yourself and myself) to the list of authors at the beginning of the file though - given the amount of changes the driver has received compared to Tomas' original.
Thanks for all your work, -- - Harald Welte <laforge@openmoko.org> http://openmoko.org/ ============================================================================ Software for the world's first truly open Free Software mobile phone
| |