lkml.org 
[lkml]   [2008]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [Linux-ATM-General] [PATCH] firmware: convert Ambassador ATM driver to request_firmware()
    From
    Date
    On Mon, 2008-06-30 at 09:59 -0400, Chas Williams (CONTRACTOR) wrote:
    > In message <1214832072.10393.342.camel@pmac.infradead.org>,David Woodhouse writ
    > es:
    > >On Mon, 2008-06-30 at 09:15 -0400, Chas Williams (CONTRACTOR) wrote:
    > >> In message <1214831362.10393.340.camel@pmac.infradead.org>,David Woodhouse w
    > >rit
    > >> es:
    > >> >And wasn't it sba200e_ecd.bin ?
    > >>
    > >> oops. sparc is big endian. adding the const we have...
    > >
    > >You probably still want the ifdefs for MODULE_FIRMWARE().
    >
    > i removed the #ifdef's from around MODULE_LICENSE(). there shouldnt
    > be any need for #ifdef's around MODULE_FIRMWARE() either.

    Unless you put #ifdef CONFIG_SBUS around the
    MODULE_FIRMWARE("sba200e_ecd.bin") you will be requesting that firmware
    even on non-sbus machines. Likewise little-endian vs. big-endian on PCI.

    --
    dwmw2



    \
     
     \ /
      Last update: 2008-06-30 16:57    [W:0.020 / U:187.528 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site