lkml.org 
[lkml]   [2008]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: PATCH: 2.6.26-rc8: Fix IRQF_DISABLED for shared interrupts
On Mon, 30 Jun 2008, David Brownell wrote:

> On Monday 30 June 2008, Stefan Becker wrote:
> > It seems IRQF_SHARED | IRQF_DISABLED has already been discussed several
> > times on LKML:
>
> Given that, I'm surprised that nobody has added a warning that
> prints when those two flags are both passed to request_irq().
>
> The problems have been around for a long time, "tested" and known
> to be broken. They'll never go away without nag messages nudging
> developers to fix the problems.
>
>
> > Alan: should I try to implement his choice (f) insteadn, i.e. drop
> > IRQF_DISABLED from USB HCD interrupts and disable interrupts in
> > usb_hcd_irq() instead?
>
> That's the best solution for USB, given that IRQF_DISABLED isn't
> going to do what it claims to do.

I agree. Note that IRQF_DISABLED is used in hcd_pci.c as well as in
quite a few files in drivers/usb/host.

Alan Stern



\
 
 \ /
  Last update: 2008-06-30 16:39    [W:0.088 / U:0.996 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site