Messages in this thread | | | Date | Mon, 30 Jun 2008 12:23:32 +0200 | From | Ingo Molnar <> | Subject | Re: [patch] x86: add compilation checks to pci_unmap_ macros |
| |
* Matti Linnanvuori <mattilinn@gmail.com> wrote:
> From: Matti Linnanvuori <mattilinnanvuori@yahoo.com> > > Add compilation checks to pci_unmap_ macros.
> -#define DECLARE_PCI_UNMAP_ADDR(ADDR_NAME) > -#define DECLARE_PCI_UNMAP_LEN(LEN_NAME) > -#define pci_unmap_addr(PTR, ADDR_NAME) (0) > -#define pci_unmap_addr_set(PTR, ADDR_NAME, VAL) do { } while (0) > -#define pci_unmap_len(PTR, LEN_NAME) (0) > -#define pci_unmap_len_set(PTR, LEN_NAME, VAL) do { } while (0) > +#define DECLARE_PCI_UNMAP_ADDR(ADDR_NAME) dma_addr_t ADDR_NAME[0]; > +#define DECLARE_PCI_UNMAP_LEN(LEN_NAME) unsigned LEN_NAME[0]; > +#define pci_unmap_addr(PTR, ADDR_NAME) sizeof((PTR)->ADDR_NAME) > +#define pci_unmap_addr_set(PTR, ADDR_NAME, VAL) \ > + do { break; } while (pci_unmap_addr(PTR, ADDR_NAME)) > +#define pci_unmap_len(PTR, LEN_NAME) sizeof((PTR)->LEN_NAME) > +#define pci_unmap_len_set(PTR, LEN_NAME, VAL) \ > + do { break; } while (pci_unmap_len(PTR, LEN_NAME))
applied to tip/x86/cleanups - thanks Matti.
Would you be interested in doing a small cleanup as well and convert the parameter names to non-shouting lower-case letters? (If you do it then please do it as a delta patch as i've already applied your current patch.)
Ingo
| |