lkml.org 
[lkml]   [2008]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] x86: add compilation checks to pci_unmap_ macros

* Matti Linnanvuori <mattilinn@gmail.com> wrote:

> From: Matti Linnanvuori <mattilinnanvuori@yahoo.com>
>
> Add compilation checks to pci_unmap_ macros.

> -#define DECLARE_PCI_UNMAP_ADDR(ADDR_NAME)
> -#define DECLARE_PCI_UNMAP_LEN(LEN_NAME)
> -#define pci_unmap_addr(PTR, ADDR_NAME) (0)
> -#define pci_unmap_addr_set(PTR, ADDR_NAME, VAL) do { } while (0)
> -#define pci_unmap_len(PTR, LEN_NAME) (0)
> -#define pci_unmap_len_set(PTR, LEN_NAME, VAL) do { } while (0)
> +#define DECLARE_PCI_UNMAP_ADDR(ADDR_NAME) dma_addr_t ADDR_NAME[0];
> +#define DECLARE_PCI_UNMAP_LEN(LEN_NAME) unsigned LEN_NAME[0];
> +#define pci_unmap_addr(PTR, ADDR_NAME) sizeof((PTR)->ADDR_NAME)
> +#define pci_unmap_addr_set(PTR, ADDR_NAME, VAL) \
> + do { break; } while (pci_unmap_addr(PTR, ADDR_NAME))
> +#define pci_unmap_len(PTR, LEN_NAME) sizeof((PTR)->LEN_NAME)
> +#define pci_unmap_len_set(PTR, LEN_NAME, VAL) \
> + do { break; } while (pci_unmap_len(PTR, LEN_NAME))

applied to tip/x86/cleanups - thanks Matti.

Would you be interested in doing a small cleanup as well and convert the
parameter names to non-shouting lower-case letters? (If you do it then
please do it as a delta patch as i've already applied your current
patch.)

Ingo


\
 
 \ /
  Last update: 2008-06-30 12:27    [W:0.181 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site