Messages in this thread | | | Date | Tue, 3 Jun 2008 09:06:26 +0300 | From | "Pekka Enberg" <> | Subject | Re: [PATCH -mm] clean up duplicated alloc/free_thread_info |
| |
On Tue, Jun 3, 2008 at 8:02 AM, FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> wrote: > Is there a reason we duplicate alloc/free_thread_info defines on many > platforms?
No. The patch looks good.
On Tue, Jun 3, 2008 at 8:02 AM, FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> wrote: > Note: > > - I don't like __HAVE_ARCH_THREAD_INFO_ALLOCATOR name much. I chose > that name just because we define __HAVE_ARCH_TASK_STRUCT_ALLOCATOR in > the same place. > > - frv, m32r, mips, mn10300, and sh uses kmalloc/kfree instead of > __get_free_pages/free_pages. I let them alone but it could remove more > code if __get_free_pages/free_pages works for them.
Yeah, I too have wondered why some architectures use kmalloc() whereas others use the page allocator. Is THREAD_SIZE significantly smaller than PAGE_SIZE for those?
| |