Messages in this thread |  | | | Date | Tue, 03 Jun 2008 13:35:13 +0900 | | From | KOSAKI Motohiro <> | | Subject | Re: [PATCH] vmallocinfo: Add NUMA informations |
| |
> >> + for (nr = 0; nr < MAX_NUMNODES; nr++) > >> + if (counters[nr]) > >> + seq_printf(m, " N%u=%u", nr, counters[nr]); > > > > for_each_node_state(n, N_HIGH_MEMORY) is better? > > because MAX_NUMNODES has offten very large value. > > > Yes, good idea, thank you. > > I also used nr_node_ids instead of MAX_NUMNODES in this second version :
Thank you! looks goot to me. and, my test fouund no bug.
Tested-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cristoph, What do you think?
|  |