lkml.org 
[lkml]   [2008]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 21/28] PNPACPI: ignore _PRS interrupt numbers larger than PNP_IRQ_NR
    ACPI Extended Interrupt Descriptors can encode 32-bit interrupt
    numbers, so an interrupt number may exceed the size of the bitmap
    we use to track possible IRQ settings.

    To avoid corrupting memory, complain and ignore too-large interrupt
    numbers.

    There's similar code in pnpacpi_parse_irq_option(), but I didn't
    change that because the small IRQ descriptor can only encode
    IRQs 0-15, which do not exceed bitmap size.

    In the future, we could handle IRQ numbers greater than PNP_IRQ_NR
    by replacing the bitmap with a table or list.

    Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
    Acked-by: Rene Herman <rene.herman@gmail.com>

    Index: work14/drivers/pnp/pnpacpi/rsparser.c
    ===================================================================
    --- work14.orig/drivers/pnp/pnpacpi/rsparser.c 2008-06-24 17:09:17.000000000 -0600
    +++ work14/drivers/pnp/pnpacpi/rsparser.c 2008-06-27 14:46:33.000000000 -0600
    @@ -455,9 +455,16 @@ static __init void pnpacpi_parse_ext_irq
    return;

    bitmap_zero(map.bits, PNP_IRQ_NR);
    - for (i = 0; i < p->interrupt_count; i++)
    - if (p->interrupts[i])
    - __set_bit(p->interrupts[i], map.bits);
    + for (i = 0; i < p->interrupt_count; i++) {
    + if (p->interrupts[i]) {
    + if (p->interrupts[i] < PNP_IRQ_NR)
    + __set_bit(p->interrupts[i], map.bits);
    + else
    + dev_err(&dev->dev, "ignoring IRQ %d option "
    + "(too large for %d entry bitmap)\n",
    + p->interrupts[i], PNP_IRQ_NR);
    + }
    + }

    flags = irq_flags(p->triggering, p->polarity, p->sharable);
    pnp_register_irq_resource(dev, option, &map, flags);
    --


    \
     
     \ /
      Last update: 2008-06-28 01:13    [W:0.032 / U:29.968 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site