Messages in this thread | | | From | Roland McGrath <> | Subject | Re: [PATCH 1/3] sched: fix TASK_WAKEKILL vs SIGKILL race | Date | Mon, 9 Jun 2008 14:10:50 -0700 (PDT) |
| |
I was also concerned about perturbing the schedule() hot path with the original patch. With this version making signal_pending_state() inline, I think it's good.
> Note this "__TASK_STOPPED | __TASK_TRACED" check in signal_pending_state(). > This is needed to preserve the current behaviour (ptrace_notify). I hope > this check will be removed soon, but this (afaics good) change needs the > separate discussion.
Agreed. I think it might actually already be safe to drop it, but we can get to that after this settles.
Thanks, Roland
| |