Messages in this thread | | | Date | Thu, 26 Jun 2008 22:36:48 -0700 | From | "Yinghai Lu" <> | Subject | Re: [PATCH 1/2] x86 boot: add E820_RESVD_KERN |
| |
On Thu, Jun 26, 2008 at 8:03 PM, Huang, Ying <ying.huang@intel.com> wrote: > On Thu, 2008-06-26 at 19:52 -0700, Yinghai Lu wrote: >> On Thu, Jun 26, 2008 at 7:48 PM, Huang, Ying <ying.huang@intel.com> wrote: >> > On Thu, 2008-06-26 at 19:22 -0700, Yinghai Lu wrote: >> >> On Thu, Jun 26, 2008 at 2:47 AM, Yinghai Lu <yhlu.kernel@gmail.com> wrote: >> >> > On Thu, Jun 26, 2008 at 12:48 AM, Huang, Ying <ying.huang@intel.com> wrote: >> >> >> On Thu, 2008-06-26 at 00:25 -0700, Yinghai Lu wrote: >> >> >> [...] >> >> >>> > if (pfn >= limit_pfn) >> >> >>> > @@ -977,7 +978,7 @@ u64 __init early_reserve_e820(u64 startt >> >> >>> > return 0; >> >> >>> > >> >> >>> > addr = round_down(start + size - sizet, align); >> >> >>> > - e820_update_range(addr, sizet, E820_RAM, E820_RESERVED); >> >> >>> > + e820_update_range(addr, sizet, E820_RAM, E820_RESVD_KERN); >> >> >>> >> >> >>> this line is not needed. >> >> >> >> >> >> Why? Memory reserved by early_rserved_e820 should not be saved during >> >> >> hibernation? shoudl not be saved by kdump? >> >> >> >> > >> > Can you tell me why this line is not needed? >> >> that function only have one user. the mpc reserve_new, so we want it >> to be E820_RESERVED, and kexec tools could have that range reserved, >> the next kernel will not overwrite the updated mptable. > > This is OK for kexec. Does it need to be saved by kdump? Does it need to > be saved by hibernation (suspend to disk)?
the function is only called when alloc_mptable is specified in command line.
YH
| |