lkml.org 
[lkml]   [2008]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 52/60] microblaze_v4: fcntl.h sockios.h ucontext.h
    Date
    On Thursday 26 June 2008, monstr@seznam.cz wrote:
    >  include/asm-generic/sockios.h     |   23 +++++++++++++++++++++++
    >  include/asm-generic/ucontext.h    |   24 ++++++++++++++++++++++++
    >  include/asm-microblaze/fcntl.h    |    1 +
    >  include/asm-microblaze/sockios.h  |   23 +++++++++++++++++++++++
    >  include/asm-microblaze/ucontext.h |    1 +

    The grouping of files seems rather arbitrary here. What would be really
    good here is if you had all the new asm-generic files as separate patches,
    i.e. as a series adding them independent of the microblaze patches so
    that the other arch maintainers could look at them and start using
    the same files, and then add all your trivial wrappers in a single
    patch.

    Also, the sockios file here looks like it should be in asm-generic.

    The contents of the files in this patch all look good, they are
    identical to the majority of the other architectures.

    Arnd <><
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2008-06-26 17:45    [W:4.037 / U:0.628 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site