lkml.org 
[lkml]   [2008]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 29/50] KVM: x86 emulator: simplify push imm8 emulation
    Date
    Instead of fetching the data explicitly, use SrcImmByte.

    Signed-off-by: Avi Kivity <avi@qumranet.com>
    ---
    arch/x86/kvm/x86_emulate.c | 4 +---
    1 files changed, 1 insertions(+), 3 deletions(-)

    diff --git a/arch/x86/kvm/x86_emulate.c b/arch/x86/kvm/x86_emulate.c
    index 2a9db4d..4e037ea 100644
    --- a/arch/x86/kvm/x86_emulate.c
    +++ b/arch/x86/kvm/x86_emulate.c
    @@ -121,7 +121,7 @@ static u16 opcode_table[256] = {
    0, 0, 0, DstReg | SrcMem32 | ModRM | Mov /* movsxd (x86/64) */ ,
    0, 0, 0, 0,
    /* 0x68 - 0x6F */
    - 0, 0, ImplicitOps | Mov | Stack, 0,
    + 0, 0, SrcImmByte | Mov | Stack, 0,
    SrcNone | ByteOp | ImplicitOps, SrcNone | ImplicitOps, /* insb, insw/insd */
    SrcNone | ByteOp | ImplicitOps, SrcNone | ImplicitOps, /* outsb, outsw/outsd */
    /* 0x70 - 0x77 */
    @@ -1425,8 +1425,6 @@ special_insn:
    c->dst.val = (s32) c->src.val;
    break;
    case 0x6a: /* push imm8 */
    - c->src.val = 0L;
    - c->src.val = insn_fetch(s8, 1, c->eip);
    emulate_push(ctxt);
    break;
    case 0x6c: /* insb */
    --
    1.5.6


    \
     
     \ /
      Last update: 2008-06-26 14:37    [W:4.139 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site