Messages in this thread | | | Date | Thu, 26 Jun 2008 13:01:13 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 00/16] x86: merge setup_32/64.c |
| |
* Yinghai Lu <yhlu.kernel@gmail.com> wrote:
> > #include <asm/mpspec.h> > > #include <asm/setup.h> > > #include <asm/arch_hooks.h> > > +#include <asm/efi.h> > > #include <asm/sections.h> > > #include <asm/dmi.h> > > #include <asm/io_apic.h> > > checkpatch.pl want me to remove that.
checkpatch.pl is right about that, but the proper fix would be to decode this dependency - why isnt it enough to include linux/efi.h?
Ingo
| |