lkml.org 
[lkml]   [2008]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] module: make symbol_put_addr() work for all exported symbols
On Mon, 23 Jun 2008, Rusty Russell wrote:

> It might be better to centralize all these iterators, and create a
> proper iterator function. Any chance you could rewrite it on top of
> this patch? (Lightly tested)

Hi Rusty,

yes, this looks like better approach. I will respin that patch.

> +struct find_symbol_arg
> +{
> + /* Input */
> + const char *name;
> + bool gplok;
> + bool warn;
> +
> + /* Output */
> + struct module *owner;
> + const unsigned long *crc;
> + unsigned long value;
> +};

I see two options how to do this -- either I can make 'value' input
parameter too, so that find_symbol_in_section() could perform lookup
either according to address or according to name (whatever is specified in
the passed struct find_symbol_arg), or I can do a completely new lookup
function for address-wise lookups. What would you prefer? I don't have any
strong preference either way.

Thanks,

--
Jiri Kosina
SUSE Labs


\
 
 \ /
  Last update: 2008-06-25 10:41    [W:1.777 / U:0.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site