Messages in this thread | | | Date | Wed, 25 Jun 2008 16:18:31 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH 03 of 36] x86: add memory barriers to wrmsr |
| |
Arjan van de Ven wrote: >>> >> I suppose, though I would be inclined to put the barriers in the >> wrmsr macro itself to act as documentation. > > > yeah I meant like this: > > static inline void native_write_msr(unsigned int msr, > unsigned low, unsigned high) > { > barrier(); > asm volatile("wrmsr" : : "c" (msr), "a"(low), "d" (high)); > barrier(); > } > > or in the same in the thing that calls this. >
Actually, I believe the barrier(); before is actually incorrect, since it would affect the wrmsr() register arguments rather than the wrmsr instruction itself.
-hpa
| |