| Date | Tue, 24 Jun 2008 21:44:41 -0700 | From | Arjan van de Ven <> | Subject | Re: [PATCH 03 of 36] x86: add memory barriers to wrmsr |
| |
On Wed, 25 Jun 2008 00:18:59 -0400 Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> wrmsr is a special instruction which can have arbitrary system-wide > effects. We don't want the compiler to reorder it with respect to > memory operations, so make it a memory barrier.
it's more readable for several of these cases to stick a barrier(); in front and after it to be honest; that makes it more explicit that these are deliberate compiler barriers rather than "actual" memory access...
-- If you want to reach me at my work email, use arjan@linux.intel.com For development, discussion and tips for power savings, visit http://www.lesswatts.org
|