lkml.org 
[lkml]   [2008]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [2.6 patch] remove pcibios_update_resource() functions
Date
On Tuesday, June 17, 2008 3:33 pm Adrian Bunk wrote:
> Russell King did the following back in 2003:
>
> <-- snip -->
>
> [PCI] pci-9: Kill per-architecture pcibios_update_resource()
>
> Kill pcibios_update_resource(), replacing it with
> pci_update_resource(). pci_update_resource() uses pcibios_resource_to_bus()
> to convert a resource to a device BAR - the transformation should be
> exactly the same as the transformation used for the PCI bridges.

Ralf, I assume you're ok with this?

Thanks,
Jesse

> diff --git a/arch/mips/pmc-sierra/yosemite/ht.c
> b/arch/mips/pmc-sierra/yosemite/ht.c index 6380662..678388f 100644
> --- a/arch/mips/pmc-sierra/yosemite/ht.c
> +++ b/arch/mips/pmc-sierra/yosemite/ht.c
> @@ -345,42 +345,6 @@ int pcibios_enable_device(struct pci_dev *dev, int
> mask) return pcibios_enable_resources(dev);
> }
>
> -
> -
> -void pcibios_update_resource(struct pci_dev *dev, struct resource *root,
> - struct resource *res, int resource)
> -{
> - u32 new, check;
> - int reg;
> -
> - return;
> -
> - new = res->start | (res->flags & PCI_REGION_FLAG_MASK);
> - if (resource < 6) {
> - reg = PCI_BASE_ADDRESS_0 + 4 * resource;
> - } else if (resource == PCI_ROM_RESOURCE) {
> - res->flags |= IORESOURCE_ROM_ENABLE;
> - reg = dev->rom_base_reg;
> - } else {
> - /*
> - * Somebody might have asked allocation of a non-standard
> - * resource
> - */
> - return;
> - }
> -
> - pci_write_config_dword(dev, reg, new);
> - pci_read_config_dword(dev, reg, &check);
> - if ((new ^ check) &
> - ((new & PCI_BASE_ADDRESS_SPACE_IO) ? PCI_BASE_ADDRESS_IO_MASK
> : - PCI_BASE_ADDRESS_MEM_MASK)) {
> - printk(KERN_ERR "PCI: Error while updating region "
> - "%s/%d (%08x != %08x)\n", pci_name(dev), resource,
> - new, check);
> - }
> -}
> -
> -
> void pcibios_align_resource(void *data, struct resource *res,
> resource_size_t size, resource_size_t align)
> {



\
 
 \ /
  Last update: 2008-06-26 01:05    [W:0.085 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site