Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH] module: make symbol_put_addr() work for all exported symbols | Date | Thu, 26 Jun 2008 01:37:04 +1000 |
| |
On Wednesday 25 June 2008 18:37:37 Jiri Kosina wrote: > On Mon, 23 Jun 2008, Rusty Russell wrote: > > It might be better to centralize all these iterators, and create a > > proper iterator function. Any chance you could rewrite it on top of > > this patch? (Lightly tested) > > Hi Rusty,
Hi Jiri,
> I see two options how to do this -- either I can make 'value' input > parameter too, so that find_symbol_in_section() could perform lookup > either according to address or according to name (whatever is specified in > the passed struct find_symbol_arg), or I can do a completely new lookup > function for address-wise lookups. What would you prefer? I don't have any > strong preference either way.
A new lookup function (and hence a new structure) I think. It'll be clearer.
Cheers, Rusty.
| |