lkml.org 
[lkml]   [2008]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 18/21] Cleanup iucv printk messages.
    From: Ursula Braun <braunu@de.ibm.com>

    Cc: David S. Miller <davem@davemloft.net>
    Signed-off-by: Ursula Braun <braunu@de.ibm.com>
    ---

    net/iucv/af_iucv.c | 8 ++------
    net/iucv/iucv.c | 9 ++-------
    2 files changed, 4 insertions(+), 13 deletions(-)

    Index: quilt-2.6/net/iucv/af_iucv.c
    ===================================================================
    --- quilt-2.6.orig/net/iucv/af_iucv.c
    +++ quilt-2.6/net/iucv/af_iucv.c
    @@ -1135,8 +1135,7 @@ static void iucv_callback_txdone(struct
    if (this)
    kfree_skb(this);
    }
    - if (!this)
    - printk(KERN_ERR "AF_IUCV msg tag %u not found\n", msg->tag);
    + BUG_ON(!this);

    if (sk->sk_state == IUCV_CLOSING) {
    if (skb_queue_empty(&iucv_sk(sk)->send_skb_q)) {
    @@ -1196,7 +1195,7 @@ static int __init afiucv_init(void)
    }
    cpcmd("QUERY USERID", iucv_userid, sizeof(iucv_userid), &err);
    if (unlikely(err)) {
    - printk(KERN_ERR "AF_IUCV needs the VM userid\n");
    + WARN_ON(err);
    err = -EPROTONOSUPPORT;
    goto out;
    }
    @@ -1210,7 +1209,6 @@ static int __init afiucv_init(void)
    err = sock_register(&iucv_sock_family_ops);
    if (err)
    goto out_proto;
    - printk(KERN_INFO "AF_IUCV lowlevel driver initialized\n");
    return 0;

    out_proto:
    @@ -1226,8 +1224,6 @@ static void __exit afiucv_exit(void)
    sock_unregister(PF_IUCV);
    proto_unregister(&iucv_proto);
    iucv_unregister(&af_iucv_handler, 0);
    -
    - printk(KERN_INFO "AF_IUCV lowlevel driver unloaded\n");
    }

    module_init(afiucv_init);
    Index: quilt-2.6/net/iucv/iucv.c
    ===================================================================
    --- quilt-2.6.orig/net/iucv/iucv.c
    +++ quilt-2.6/net/iucv/iucv.c
    @@ -1559,16 +1559,11 @@ static void iucv_external_interrupt(u16

    p = iucv_irq_data[smp_processor_id()];
    if (p->ippathid >= iucv_max_pathid) {
    - printk(KERN_WARNING "iucv_do_int: Got interrupt with "
    - "pathid %d > max_connections (%ld)\n",
    - p->ippathid, iucv_max_pathid - 1);
    + WARN_ON(p->ippathid >= iucv_max_pathid);
    iucv_sever_pathid(p->ippathid, iucv_error_no_listener);
    return;
    }
    - if (p->iptype < 0x01 || p->iptype > 0x09) {
    - printk(KERN_ERR "iucv_do_int: unknown iucv interrupt\n");
    - return;
    - }
    + BUG_ON(p->iptype < 0x01 || p->iptype > 0x09);
    work = kmalloc(sizeof(struct iucv_irq_list), GFP_ATOMIC);
    if (!work) {
    printk(KERN_WARNING "iucv_external_interrupt: out of memory\n");
    --
    blue skies,
    Martin.

    "Reality continues to ruin my life." - Calvin.



    \
     
     \ /
      Last update: 2008-06-25 16:43    [W:0.023 / U:127.604 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site