Messages in this thread | | | Date | Tue, 24 Jun 2008 10:07:44 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH 1/2] Avoid bio_endio recursion |
| |
On Tue, Jun 24 2008, Mikulas Patocka wrote: > Hi > > bio_endio calls bi_end_io callback. In case of stacked devices (raid, dm), > bio_end_io may call bio_endio again, up to an unspecified length. > > The crash because of stack overflow was really observed on sparc64. And > this recursion was one of the contributing factors (using 9 stack frames > --- that is 1728 bytes).
Looks good, I like the concept. Can you please make it a little less goto driven, though? The next_bio and goto next_bio could just be a while().
-- Jens Axboe
| |