Messages in this thread | | | Date | Tue, 24 Jun 2008 19:18:23 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not decimal in some kernel info printks |
| |
Paul Jackson wrote: > hpa wrote: >> that would have to be %#10lx. > > Hmmm ... the '#' is a good idea, instead of an explicit "0x". > > Do we want zero padding as well, with "0#8lx" ? > > Zone PFN ranges: > DMA 0x00000000 -> 0x00001000 > DMA32 0x00001000 -> 0x00100000 > Normal 0x00100000 -> 0x00428000 > > or right aligned, space padded: > > Zone PFN ranges: > DMA 0x0 -> 0x1000 > DMA32 0x1000 -> 0x100000 > Normal 0x100000 -> 0x428000 > > I like the zero padding here myself. >
Yes, zero padding.
What we really should have is %p produce this format. For some odd reason, right now %p produces numbers without the 0x prefix.
-h
| |