lkml.org 
[lkml]   [2008]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [rfc patch 3/4] splice: remove confirm from pipe_buf_operations


On Tue, 24 Jun 2008, Miklos Szeredi wrote:
>
> Right. But what if it's invalidated *before* becoming uptodate (if
> you'd read my mail further, I discussed this).
>
> Why does invalidate_complete_page2() do ClearPageUptodate()? Dunno,
> maybe it shoulnd't. But that would need a rather thorough audit of
> all code checking PageUptodate()...

Quite frankly, that shouldn't happen in the first place. Nothing should
clear up-to-date on a page that is locked. Doesn't
invalidate_complete_page() wait for the page to be unlocked already?

That said, the VM people already discussed (I think for other reasons),
removing the ClearPageUptodate(), because it has problems. There's talk
about just unhashing the page or moving it to another radix tree or
something.

Linus


\
 
 \ /
  Last update: 2008-06-24 21:49    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site