Messages in this thread |  | | | Date | Tue, 24 Jun 2008 07:27:14 -0700 | | From | "Paul Menage" <> | | Subject | Re: [PATCH 2/8] CGroup Files: Add write_string cgroup control file method |
| |
On Sun, Jun 22, 2008 at 7:32 AM, Balbir Singh <balbir@linux.vnet.ibm.com> wrote: >> +static ssize_t cgroup_write_string(struct cgroup *cgrp, struct cftype *cft, >> + struct file *file, >> + const char __user *userbuf, >> + size_t nbytes, loff_t *unused_ppos) >> +{ >> + char local_buffer[64]; > > 64? a define would be more meaningful
Potentially, although it would be unlikely to be reused anywhere else. It's just meant to be a size that's big enough for any numerical value, and for the vast majority of other writes.
Paul
|  |