Messages in this thread | | | Date | Tue, 24 Jun 2008 13:54:00 +0200 | From | Ingo Molnar <> | Subject | Re: [RFC PATCH] x86:Use cpu_khz for loops_per_jiffy calculation |
| |
* Alok Kataria <akataria@vmware.com> wrote:
> On Mon, 2008-06-23 at 16:47 -0700, Ingo Molnar wrote: > > * Alok Kataria <akataria@vmware.com> wrote: > > > > > IMO, lpj_tsc explains how is this variable initialized. But thinking > > > about it, maybe we should rename it to "lpj_timer" ? > > > > ok. But instead of 'lpj_timer' i'd suggest to use something like > > 'lpj_fine' - as this really is about finegrained measurements. > > Ok. > > > > I'd suggest a delta patch against tip/master that renames all those > > tsc_* variables to fine_*. So tsc_rate_min would become fine_rate_min, > > etc. > > Ingo, tsc_rate_min etc are related to the timer rate so calling it > fine_rate_min would be confusing IMO. Instead i call it as > timer_rate_min. Below is the patch on tip/master. Tested on both 32 > and 64 bit environment, tree works fine for me.
applied to tip/x86/delay - thanks Alok.
Ingo
| |