Messages in this thread | | | Date | Tue, 24 Jun 2008 18:59:28 +0900 | From | KAMEZAWA Hiroyuki <> | Subject | Re: [RFC][PATCH] putback_lru_page()/unevictable page handling rework v3 |
| |
On Tue, 24 Jun 2008 18:49:05 +0900 KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
> > + mem_cgroup_move_lists(page, lru); > > + > > + /* > > + * page's status can change while we move it among lru. If an evictable > > + * page is on unevictable list, it never be freed. To avoid that, > > + * check after we added it to the list, again. > > + */ > > + if (lru == LRU_UNEVICTABLE && page_evictable(page, NULL)) { > > + if (!isolate_lru_page(page)) { > > + put_page(page); > > + goto redo; > > at this point, We should call ClearPageUnevictable(). > otherwise, BUG() is called on isolate_lru_pages(). > Sure. thanks, -Kame
| |