lkml.org 
[lkml]   [2008]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RESEND PATCH 1/3] e1000e: set CONFIG_E1000E=y in x86 defconfigs
Ingo Molnar wrote:
> * Jeff Kirsher <jeffrey.t.kirsher@intel.com> wrote:
>
>> From: Auke Kok <auke-jan.h.kok@intel.com>
>>
>> This adds to the already default CONFIG_E1000=y in these files.
>>
>> Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
>> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
>> ---
>>
>> arch/x86/configs/i386_defconfig | 1 +
>> arch/x86/configs/x86_64_defconfig | 1 +
>
> that is not an e1000 patch but an arch/x86 defconfig patch. NAK on this
> route of patch propagation.

But it's dependent on an e1000 patch. Maybe we could follow the lead of
ppc and other arch maintainers, and work together?

Typically if there are arch dependencies and little drivers/net changes,
I'll ACK the drivers/net change and then let it go through the arch tree.

In this case, there is far more drivers/net code, so it would make the
most sense to work with you to change the defconfigs to your liking, and
then merge them via netdev when the other E1000 changes go in.

Jeff






\
 
 \ /
  Last update: 2008-06-24 01:23    [W:0.111 / U:0.876 seconds]
©2003-2014 Jasper Spaans. Advertise on this site