lkml.org 
[lkml]   [2008]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch] ADJ_OFFSET_SS_READ and capabilities
    Hi Roman, John,

    ADJ_OFFSET_SS_READ is a read-only operation. Therefore, it seems
    reasonable not to require any capability (as is the case when 'modes'
    is zero. See the patch below. Does this change seem reasonable?

    Cheers,

    Michael

    --- linux-2.6.26-rc5/kernel/time/ntp.c 2008-06-13 11:16:51.000000000 +0200
    +++ linux-2.6.26-rc5-p/kernel/time/ntp.c 2008-06-22 07:31:43.000000000 +0200
    @@ -281,7 +281,8 @@
    int result;

    /* In order to modify anything, you gotta be super-user! */
    - if (txc->modes && !capable(CAP_SYS_TIME))
    + if (txc->modes && txc->modes != ADJ_OFFSET_SS_READ &&
    + !capable(CAP_SYS_TIME))
    return -EPERM;

    /* Now we validate the data before disabling interrupts */



    \
     
     \ /
      Last update: 2008-06-23 10:05    [W:0.022 / U:0.108 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site