Messages in this thread Patch in this message | | | Date | Mon, 23 Jun 2008 16:04:48 -0700 | From | Greg KH <> | Subject | [patch 09/10] hwmon: (adt7473) Initialize max_duty_at_overheat before use |
| |
2.6.25.9-stable review patch. If anyone has any objections, please let us know.
------------------ From: Jean Delvare <khali@linux-fr.org>
commit ed4ec814e45ae8b1596aea0a29b92f6c3614acaa upstream
data->max_duty_at_overheat is not updated in adt7473_update_device, so it might be used before it is initialized (if the user reads from sysfs file max_duty_at_crit before writing to it.)
Signed-off-by: Jean Delvare <khali@linux-fr.org> Acked-by: Darrick J. Wong <djwong@us.ibm.com> Signed-off-by: Mark M. Hoffman <mhoffman@lightlink.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
--- drivers/hwmon/adt7473.c | 3 +++ 1 file changed, 3 insertions(+)
--- a/drivers/hwmon/adt7473.c +++ b/drivers/hwmon/adt7473.c @@ -309,6 +309,9 @@ no_sensor_update: ADT7473_REG_PWM_BHVR(i)); } + i = i2c_smbus_read_byte_data(client, ADT7473_REG_CFG4); + data->max_duty_at_overheat = !!(i & ADT7473_CFG4_MAX_DUTY_AT_OVT); + data->limits_last_updated = local_jiffies; data->limits_valid = 1; --
| |