Messages in this thread | | | Date | Mon, 23 Jun 2008 20:14:51 +0200 (CEST) | From | Geert Uytterhoeven <> | Subject | Re: [2.6 patch] drivers/macintosh/: possible cleanups |
| |
On Mon, 23 Jun 2008, Adrian Bunk wrote: > On Tue, Jun 10, 2008 at 10:21:25AM +1000, Stephen Rothwell wrote: > > On Tue, 10 Jun 2008 01:23:12 +0300 Adrian Bunk <bunk@kernel.org> wrote: > > > > > > +++ b/drivers/macintosh/adbhid.c > > > @@ -75,7 +75,7 @@ static struct notifier_block adbhid_adb_notifier = { > > > #define ADB_KEY_POWER_OLD 0x7e > > > #define ADB_KEY_POWER 0x7f > > > > > > -u16 adb_to_linux_keycodes[128] = { > > > +static u16 adb_to_linux_keycodes[128] = { > > > > This could be const as well. > > Updated patch below. > > cu > Adrian > > <-- snip --> > > This patch contains the following possible cleanups: > - make the following needlessly global code static: > - adb.c: adb_controller > - adb.c: adb_init() > - adbhid.c: adb_to_linux_keycodes[] (also make it const) > - via-pmu68k.c: backlight_level > - via-pmu68k.c: backlight_enabled > - remove the following unused code: > - via-pmu68k.c: sleep_notifier_list > > Signed-off-by: Adrian Bunk <bunk@kernel.org>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
I assume Paulus will take it, as he controls more Macs?
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |