lkml.org 
[lkml]   [2008]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2.6.26-rc] ACPI Thermal Zone driver breaks lm-sensors 2 userspace
    Linus, Rene, et al:

    * Rene Herman <rene.herman@keyaccess.nl> [2008-06-23 17:06:14 +0200]:
    > drivers/thermal/thermal_sys.c | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c
    > index 6098787..c21e03c 100644
    > --- a/drivers/thermal/thermal_sys.c
    > +++ b/drivers/thermal/thermal_sys.c
    > @@ -357,7 +357,7 @@ thermal_add_hwmon_sysfs(struct thermal_zone_device *tz)
    >
    > INIT_LIST_HEAD(&hwmon->tz_list);
    > strlcpy(hwmon->type, tz->type, THERMAL_NAME_LENGTH);
    > - hwmon->device = hwmon_device_register(NULL);
    > + hwmon->device = hwmon_device_register(&tz->device);
    > if (IS_ERR(hwmon->device)) {
    > result = PTR_ERR(hwmon->device);
    > goto free_mem;

    NACK.

    1) The bug is in libsensors (2.10), not the kernel.

    - but more importantly -

    2) This patch is broken.

    Regards,

    --
    Mark M. Hoffman
    mhoffman@lightlink.com



    \
     
     \ /
      Last update: 2008-06-23 19:15    [W:0.026 / U:1.104 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site