Messages in this thread | | | Date | Fri, 20 Jun 2008 13:39:22 +0200 | From | Ingo Molnar <> | Subject | Re: [RFC PATCH] x86:Use cpu_khz for loops_per_jiffy calculation |
| |
* Alok Kataria <akataria@vmware.com> wrote:
> loops_per_jiffy = preset_lpj; > - printk("Calibrating delay loop (skipped)... " > - "%lu.%02lu BogoMIPS preset\n", > - loops_per_jiffy/(500000/HZ), > - (loops_per_jiffy/(5000/HZ)) % 100); > + printk(KERN_DEBUG "Calibrating delay loop skipped, " > + "using preset value.. ");
i dont think the message should be eliminated from default logs via making it KERN_DEBUG - this message is a common pattern people watch out for and it does give an indication about various sorts of timing/performance trouble.
also, if you break a line like hat i'd suggest to do it like this:
> + printk(KERN_DEBUG > + "Calibrating delay loop skipped, using preset value.. ");
so that the string remains on a single line.
Ingo
| |