lkml.org 
[lkml]   [2008]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: stack overflow on Sparc64
    From
    From: Mikulas Patocka <mpatocka@redhat.com>
    Date: Fri, 20 Jun 2008 16:34:23 -0400 (EDT)

    > And what if network softirq happened here? How much stack does it consume?
    >
    > The whole overflowed stack trace has 75 functions, I was able to get rid
    > of 9 by avoiding bio_endio recursion and 10 by turning simple functions
    > into inlines. --- so is it enough or not enough for possible networking
    > calls?

    It should be OK, because the minimum stack of a (75 - 19) depth call
    chain is under 11K and within safe limits I believe.

    > Maybe a good thing would be to add a check for stack size to __do_softirq
    > and handing the softirq to ksoftirqd if there's not enough space.

    I'd rather it spit out a WARN_ON() message and a backtrace.

    Otherwise it will be considered a feature and people won't fix
    these deep call chains.


    \
     
     \ /
      Last update: 2008-06-20 22:51    [W:0.020 / U:1.248 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site