lkml.org 
[lkml]   [2008]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 43/70] io_edgeport: Fix various bogus returns to the tty layer
    Date
    From: Alan Cox <alan@redhat.com>

    The edgeport reports negative error codes to functions that do not
    expect them. This can cause ports to jam forever

    Signed-off-by: Alan Cox <alan@redhat.com>
    ---

    drivers/usb/serial/io_edgeport.c | 12 ++++++------
    1 files changed, 6 insertions(+), 6 deletions(-)


    diff --git a/drivers/usb/serial/io_edgeport.c b/drivers/usb/serial/io_edgeport.c
    index 3cb2511..44d020e 100644
    --- a/drivers/usb/serial/io_edgeport.c
    +++ b/drivers/usb/serial/io_edgeport.c
    @@ -1444,15 +1444,15 @@ static int edge_write_room(struct tty_struct *tty)
    dbg("%s", __func__);

    if (edge_port == NULL)
    - return -ENODEV;
    + return 0;
    if (edge_port->closePending)
    - return -ENODEV;
    + return 0;

    dbg("%s - port %d", __func__, port->number);

    if (!edge_port->open) {
    dbg("%s - port not opened", __func__);
    - return -EINVAL;
    + return 0;
    }

    /* total of both buffers is still txCredit */
    @@ -1484,13 +1484,13 @@ static int edge_chars_in_buffer(struct tty_struct *tty)
    dbg("%s", __func__);

    if (edge_port == NULL)
    - return -ENODEV;
    + return 0;
    if (edge_port->closePending)
    - return -ENODEV;
    + return 0;

    if (!edge_port->open) {
    dbg("%s - port not opened", __func__);
    - return -EINVAL;
    + return 0;
    }

    spin_lock_irqsave(&edge_port->ep_lock, flags);


    \
     
     \ /
      Last update: 2008-06-20 22:37    [W:0.020 / U:60.492 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site