lkml.org 
[lkml]   [2008]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH/RFC] remove irqs_disabled warning from local_bh_enable
    Date
    On Friday 20 June 2008 17:55:41 Ingo Molnar wrote:
    >
    > * Michael Buesch <mb@bu3sch.de> wrote:
    >
    > > On Friday 20 June 2008 17:27:48 Ingo Molnar wrote:
    > > > [<c012b361>] local_bh_enable_ip+0xd1/0xe0
    > > > [<c08d9f9f>] _spin_unlock_bh+0x2f/0x40
    > > > [<c0471b92>] vortex_timer+0xe2/0x3e0
    > >
    > > > real bug or false positive?
    > >
    > > Well, a timer runs with IRQs disabled, no? So this would be a bug.
    >
    > indeed - agreed :) [no time for me to fix it, but can test any rfc patch.]

    A quick workaround always is to convert the lock into an _irqsafe lock.
    Although it introduces higher overhead (interrupt-wise), it prevents the bug.
    A real fix would require to understand the locking in the driver, which I
    don't, as I never looked at the driver. :)

    --
    Greetings Michael.


    \
     
     \ /
      Last update: 2008-06-20 18:05    [W:0.021 / U:61.840 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site