Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH] mm: fix comment formatting in asm-generic/pgtable.h:__ptep_modify_prot_ | Date | Tue, 3 Jun 2008 09:45:59 +1000 |
| |
On Monday 02 June 2008 23:02:34 Jeremy Fitzhardinge wrote: > Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> > --- > include/asm-generic/pgtable.h | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > > =================================================================== > --- a/include/asm-generic/pgtable.h > +++ b/include/asm-generic/pgtable.h > @@ -201,9 +201,11 @@ > unsigned long addr, > pte_t *ptep) > { > - /* Get the current pte state, but zero it out to make it > - non-present, preventing the hardware from asynchronously > - updating it. */ > + /* > + * Get the current pte state, but zero it out to make it > + * non-present, preventing the hardware from asynchronously > + * updating it. > + */
Since there is debate over whether winged comments are a feature, I'm not sure this can be termed a "fix".
> { > - /* The pte is non-present, so there's no hardware state to > - preserve. */ > + /* > + * The pte is non-present, so there's no hardware state to > + * preserve. > + */ > set_pte_at(mm, addr, ptep, pte); > }
This will fit in one line, no?
Rusty.
| |