Messages in this thread | | | Date | Mon, 2 Jun 2008 21:09:14 +0200 | From | "Fabio Comolli" <> | Subject | Re: Section mismatch on latest git |
| |
yes, your patch fixes the warning, thanks.
(by the way, I just pulled linus' tree and it seems that the patch it's still not included and the warning is still present without it).
cheers, fabio
On Thu, May 29, 2008 at 9:01 AM, Andrew Morton <akpm@linux-foundation.org> wrote: > On Mon, 26 May 2008 10:03:21 +0200 "Fabio Comolli" <fabio.comolli@gmail.com> wrote: > >> Hi. >> I don't know it it has been reported already: >> >> WARNING: vmlinux.o(.text+0x114bb): Section mismatch in reference from >> the function nopat() to the function .cpuinit.text:pat_disable() >> The function nopat() references >> the function __cpuinit pat_disable(). >> This is often because nopat lacks a __cpuinit >> annotation or the annotation of pat_disable is wrong. >> >> Config is in attachment. >> > > This should fix it: > > --- a/arch/x86/mm/pat.c~arch-x86-mm-patc-nopat-should-be-__init > +++ a/arch/x86/mm/pat.c > @@ -34,7 +34,7 @@ void __cpuinit pat_disable(char *reason) > printk(KERN_INFO "%s\n", reason); > } > > -static int nopat(char *str) > +static int __init nopat(char *str) > { > pat_disable("PAT support disabled."); > return 0; > _ > > > It turns out that this was harmless. However it might not have been - > I think that adding the ability to suppress all these warnings was a > mistake. >
| |